Skip to content

fix: pageParam in seInternalInfiniteQuery for Vue#2714

Open
caiotarifa wants to merge 1 commit into
zenstackhq:devfrom
caiotarifa:fix/vue-infinite-query-pageparam
Open

fix: pageParam in seInternalInfiniteQuery for Vue#2714
caiotarifa wants to merge 1 commit into
zenstackhq:devfrom
caiotarifa:fix/vue-infinite-query-pageparam

Conversation

@caiotarifa

@caiotarifa caiotarifa commented Jun 16, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown

Closes #2713

Summary by CodeRabbit

  • Bug Fixes
    • Fixed infinite-query pagination to correctly use the current page parameter when constructing requests, instead of reusing the initial request parameters for subsequent pages.

@coderabbitai

coderabbitai Bot commented Jun 16, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 9974f328-4aef-49cb-acf5-87743572ab29

📥 Commits

Reviewing files that changed from the base of the PR and between 4f462a7 and 97beeda.

📒 Files selected for processing (1)
  • packages/clients/tanstack-query/src/vue.ts
📝 Walkthrough

Walkthrough

In useInternalInfiniteQuery inside the Vue TanStack Query client, the queryFn is updated to destructure pageParam from its argument and pass pageParam ?? argsValue to makeUrl, instead of always using the closed-over argsValue. No public API signatures are changed.

Changes

Vue infinite query pageParam fix

Layer / File(s) Summary
Pass pageParam to makeUrl in infinite queryFn
packages/clients/tanstack-query/src/vue.ts		 queryFn now destructures pageParam and uses pageParam ?? argsValue when constructing the request URL, aligning Vue behavior with the React adapter so pagination advances past the first page.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐇 Hippity-hop, page two was lost,
The param ignored — what a cost!
Now pageParam leads every quest,
Vue and React both pass the test.
Each next page skips just as it should,
Infinite scroll works as it could! 🥕

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately identifies the specific fix: using pageParam in useInternalInfiniteQuery for Vue, which directly addresses the core issue.
Linked Issues check ✅ Passed The code changes correctly implement the expected fix from issue #2713 by updating the queryFn to destructure pageParam and use it in URL construction, matching the React adapter pattern.
Out of Scope Changes check ✅ Passed All changes are scoped to fixing the pageParam issue in Vue's useInternalInfiniteQuery; no unrelated modifications are present.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Vue] useInfiniteFindMany ignores pageParam — infinite pagination never advances (diverges from React adapter)

1 participant

@caiotarifa